aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 24160: Add deprecation warnings for aurora client v1 command.
Date Mon, 04 Aug 2014 18:34:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24160/#review49477
-----------------------------------------------------------

Ship it!


At first I was wondering how we're going to remove these after the deprecation, but I suppose
these files are going to get rm'd completely, so lgtm.

- Joe Smith


On July 31, 2014, 11:40 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24160/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 11:40 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joe Smith.
> 
> 
> Bugs: aurora-131
>     https://issues.apache.org/jira/browse/aurora-131
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change only touches the commands in the "core" set, defined in
> core.py. If reviewers approve of this approach, I'll make similar changes to
> the other v1 commands in a subsequent review.
> 
> Testing note: unit tests for this don't seem appropriate: this is
> temporary code that doesn't actually affect the behavior of the system.
> Human verification that the alternative v2 commands in the deprecation
> messages is the only way to ensure that they're correct.
> 
> A couple of examples of the generated messages:
> 
> $ ./dist/aurora2.pex update --shards=1-3  example/mchucarroll/test/bozo examples/jobs/hello_world.aurora
> WARNING: update is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora job update example/mchucarroll/test/bozo/1,2,3
examples/jobs/hello_world.aurora --health-check-interval-seconds=3'
> 
> $ /dist/aurora2.pex kill --shards=1-3  example/mchucarroll/test/bozo examples/jobs/hello_world.aurora
> WARNING: kill is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora job kill example/mchucarroll/test/bozo/1,2,3
--config=examples/jobs/hello_world.aurora --max-total-failures=1'
> 
> ./dist/aurora2.pex create --open_browser  example/mchucarroll/test/hello examples/jobs/hello_world.aurora
> WARNING: create is an aurora clientv1 command which will be deprecated soon
> To run this command using clientv2, use 'aurora job create example/mchucarroll/test/hello
examples/jobs/hello_world.aurora --open-browser'
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py cc3d3ff565bb1b492efd5dea19db20e85dde03e8

> 
> Diff: https://reviews.apache.org/r/24160/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message