aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 24116: Defining stubs for the Update APIs.
Date Fri, 01 Aug 2014 23:38:02 GMT


> On Aug. 1, 2014, 10:02 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 611
> > <https://reviews.apache.org/r/24116/diff/5/?file=648844#file648844line611>
> >
> >     don't use a set, otherwise it begs the question why the others aren't all multi-value
as well.
> 
> Maxim Khutornenko wrote:
>     This was requested by David. Dropping it until there is a need for it.

Sorry I misread this - thought it was a set versus list thing. This is definitely required
to get all completed or active updates in a single RPC call. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49387
-----------------------------------------------------------


On Aug. 1, 2014, 10:53 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24116/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-611
>     https://issues.apache.org/jira/browse/AURORA-611
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First stab at update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2

>   src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10

> 
> Diff: https://reviews.apache.org/r/24116/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message