Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6FAF511E3E for ; Thu, 31 Jul 2014 16:04:19 +0000 (UTC) Received: (qmail 75116 invoked by uid 500); 31 Jul 2014 16:04:19 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75086 invoked by uid 500); 31 Jul 2014 16:04:19 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 75075 invoked by uid 99); 31 Jul 2014 16:04:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2014 16:04:18 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 31 Jul 2014 16:04:20 +0000 Received: (qmail 74860 invoked by uid 99); 31 Jul 2014 16:03:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2014 16:03:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5BA9F1D9A6F; Thu, 31 Jul 2014 16:03:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1807720163861108903==" MIME-Version: 1.0 Subject: Re: Review Request 24116: Defining stubs for the Update APIs. From: "Maxim Khutornenko" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 31 Jul 2014 16:03:40 -0000 Message-ID: <20140731160340.18794.91851@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24116/ X-Sender: "Maxim Khutornenko" References: <20140730213635.21934.23771@reviews.apache.org> In-Reply-To: <20140730213635.21934.23771@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1807720163861108903== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On July 30, 2014, 9:36 p.m., Bill Farner wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 692 > > > > > > How would you feel about generalizing this to support more use cases, like getting all in-progress updates? You could accept more parameters for this: > > > > Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status) Not sure I like it. What should be the output if all 3 are provided? How about something like UpdateQuery instead (similar to TaskQuery)? - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49168 ----------------------------------------------------------- On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24116/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 9:12 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-611 > https://issues.apache.org/jira/browse/AURORA-611 > > > Repository: aurora > > > Description > ------- > > First stab at update APIs. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 > src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 > > Diff: https://reviews.apache.org/r/24116/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > > --===============1807720163861108903==--