Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 579ED115E7 for ; Tue, 29 Jul 2014 18:19:05 +0000 (UTC) Received: (qmail 80495 invoked by uid 500); 29 Jul 2014 18:19:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 80455 invoked by uid 500); 29 Jul 2014 18:19:05 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 80438 invoked by uid 99); 29 Jul 2014 18:19:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jul 2014 18:19:04 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 29 Jul 2014 18:19:02 +0000 Received: (qmail 80193 invoked by uid 99); 29 Jul 2014 18:18:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jul 2014 18:18:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BC531D91CC; Tue, 29 Jul 2014 18:18:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6857979916769217853==" MIME-Version: 1.0 Subject: Re: Review Request 24059: Replace HttpModule from twitter.common with our own code. From: "Kevin Sweeney" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Tue, 29 Jul 2014 18:18:29 -0000 Message-ID: <20140729181829.18793.19342@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24059/ X-Sender: "Kevin Sweeney" References: <20140729180535.18793.29002@reviews.apache.org> In-Reply-To: <20140729180535.18793.29002@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6857979916769217853== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49002 ----------------------------------------------------------- Ship it! src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java Since this isn't in a library anymore you should be fine replacing this with Runtime.getRuntime().halt(0); (better matches the documented semantics of /abortabortabort). src/main/java/org/apache/aurora/scheduler/http/ServletModule.java TODO to reevaluate the use of Named here. src/main/java/org/apache/aurora/scheduler/http/ServletModule.java Drop this comment too? src/main/java/org/apache/aurora/scheduler/http/ServletModule.java TODO to switch this to guava Service? - Kevin Sweeney On July 29, 2014, 11:05 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24059/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 11:05 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-606 > https://issues.apache.org/jira/browse/AURORA-606 > > > Repository: aurora > > > Description > ------- > > This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). > > The only expected functional changes are the removal of /healthz (long-since deprecated in favor of /health) and /pprof/* which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). > > I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. > > > [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java > > > Diffs > ----- > > build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb > config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b > config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f > src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b > src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed > src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 > > Diff: https://reviews.apache.org/r/24059/diff/ > > > Testing > ------- > > ./gradlew clean build -Pq > > bash examples/vagrant/test_tutorial.sh > > Manually clicked around in a local scheduler. > > > Thanks, > > Bill Farner > > --===============6857979916769217853==--