Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE8C011C6E for ; Thu, 24 Jul 2014 18:06:55 +0000 (UTC) Received: (qmail 71494 invoked by uid 500); 24 Jul 2014 18:06:55 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 71452 invoked by uid 500); 24 Jul 2014 18:06:55 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 71441 invoked by uid 99); 24 Jul 2014 18:06:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jul 2014 18:06:55 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 24 Jul 2014 18:06:54 +0000 Received: (qmail 69052 invoked by uid 99); 24 Jul 2014 18:06:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jul 2014 18:06:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B0C471DB810; Thu, 24 Jul 2014 18:06:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9023820157191906718==" MIME-Version: 1.0 Subject: Re: Review Request 23834: Refactoring SchedulerCore (restartShards) From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 24 Jul 2014 18:06:20 -0000 Message-ID: <20140724180620.4204.22620@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/23834/ X-Sender: "Maxim Khutornenko" References: <20140723023642.4203.10118@reviews.apache.org> In-Reply-To: <20140723023642.4203.10118@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============9023820157191906718== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/#review48667 ----------------------------------------------------------- Ping, Kevin. - Maxim Khutornenko On July 23, 2014, 2:36 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23834/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 2:36 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-94 > https://issues.apache.org/jira/browse/AURORA-94 > > > Repository: aurora > > > Description > ------- > > Moving restartShards from SchedulerCore into SchedulerThriftInterface. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 137bd6ccafc48508ccd48004e7111fe69449152d > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f94e0447066a2e9f2e460a284c7f93eac347a91 > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 5ec7cf395080cd593a5d5291eff835f89c65dac2 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d3ac7c7585e8fcac6d26f06f53c9101aa9787808 > > Diff: https://reviews.apache.org/r/23834/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============9023820157191906718==--