Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6173416377703158200=="
MIME-Version: 1.0
Subject: Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
 implementation
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Brian Wickman" <wickman@apache.org>
Date: Thu, 24 Jul 2014 00:42:18 -0000
Message-ID: <20140724004218.4204.89236@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20140724004047.4203.88094@reviews.apache.org>
In-Reply-To: <20140724004047.4203.88094@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============6173416377703158200==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 24, 2014, 12:40 a.m., Kevin Sweeney wrote:
> > Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?

I like Brian's suggestion to use a shim script instead.  My sense is that this gives the end-user the most flexibility.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------


On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 8:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-587
>     https://issues.apache.org/jira/browse/AURORA-587
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common.  Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.)  We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review.  Open to ideas.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e 
>   src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c 
>   src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b 
>   src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23863/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


--===============6173416377703158200==--