Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76D4F1117C for ; Thu, 3 Jul 2014 02:28:23 +0000 (UTC) Received: (qmail 66033 invoked by uid 500); 3 Jul 2014 02:28:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 65990 invoked by uid 500); 3 Jul 2014 02:28:23 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 65979 invoked by uid 99); 3 Jul 2014 02:28:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 02:28:22 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 03 Jul 2014 02:28:21 +0000 Received: (qmail 65741 invoked by uid 99); 3 Jul 2014 02:28:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 02:28:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3DD061DB4DD; Thu, 3 Jul 2014 02:27:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0056786617526665210==" MIME-Version: 1.0 Subject: Re: Review Request 23105: Database-backed implementation of AttributeStore. From: "Bill Farner" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Thu, 03 Jul 2014 02:27:50 -0000 Message-ID: <20140703022750.5196.53128@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/23105/ X-Sender: "Bill Farner" References: <20140703021000.5195.10710@reviews.apache.org> In-Reply-To: <20140703021000.5195.10710@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0056786617526665210== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23105/ ----------------------------------------------------------- (Updated July 3, 2014, 2:27 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-557 https://issues.apache.org/jira/browse/AURORA-557 Repository: aurora Description ------- There are a few different characteristics of this mapper compared to others so far: - custom type handler (see AbstractTEnumTypeHandler and MaintenanceModeTypeHandler) - outer join (to allow a HostAttributes with an empty Attributes set) - batch insert via foreach - collection, and nested collection result mapping You may find this page helpful to explain the features used: http://mybatis.github.io/mybatis-3/sqlmap-xml.html#Result_Maps Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 348527997ea89fd71952a9f1ec0c67c3087f5a61 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 src/main/java/org/apache/aurora/scheduler/storage/db/EnumValueMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 77cd8abffca6bf20d753abe35ee212a7cf53668b src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java 4bb807c04e47a091c83a575850ebfc3b244bfa73 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java cc206314d93ea7b160df7f809d072f90e23cc4b3 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 65565f1bb14dd4c6425f67f27ea06566d57b65cf src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/EnumValueMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 31b98cb3107a88756694922de01fa0ba267f3e9d src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 3298eb38644b6fa7096801a69f8b88d0331ce4a7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java PRE-CREATION Diff: https://reviews.apache.org/r/23105/diff/ Testing ------- ./gradlew run -Pq Thanks, Bill Farner --===============0056786617526665210==--