Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AF83711569 for ; Wed, 2 Jul 2014 19:47:40 +0000 (UTC) Received: (qmail 57470 invoked by uid 500); 2 Jul 2014 19:47:40 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 57429 invoked by uid 500); 2 Jul 2014 19:47:40 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 57418 invoked by uid 99); 2 Jul 2014 19:47:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2014 19:47:40 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 02 Jul 2014 19:47:41 +0000 Received: (qmail 56089 invoked by uid 99); 2 Jul 2014 19:47:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jul 2014 19:47:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 77E4B1DB4A8; Wed, 2 Jul 2014 19:47:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1215733016123791453==" MIME-Version: 1.0 Subject: Review Request 23244: Fixing return value in _check_sla. From: "Maxim Khutornenko" To: "Joe Smith" Cc: "Aurora" , "Maxim Khutornenko" Date: Wed, 02 Jul 2014 19:47:04 -0000 Message-ID: <20140702194704.5195.34290@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/23244/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1215733016123791453== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ ----------------------------------------------------------- Review request for Aurora and Joe Smith. Bugs: AURORA-571 https://issues.apache.org/jira/browse/AURORA-571 Repository: aurora Description ------- Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to help troubleshooting occasional LOST tasks when draining. Diffs ----- src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java bf48db97cf882105c0b2e6b70f9a4612ce60dbe8 src/main/python/apache/aurora/admin/host_maintenance.py b5b1375b1bbaed833acf2d17ec432b3d99145fab src/test/python/apache/aurora/client/commands/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f Diff: https://reviews.apache.org/r/23244/diff/ Testing ------- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko --===============1215733016123791453==--