Return-Path: 
 <reviews-return-3066-apmail-aurora-reviews-archive=aurora.apache.org@aurora.incubator.apache.org>
X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org
Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 267F511B94
	for <apmail-aurora-reviews-archive@minotaur.apache.org>;
 Tue,  1 Jul 2014 18:51:50 +0000 (UTC)
Received: (qmail 59478 invoked by uid 500); 1 Jul 2014 18:51:50 -0000
Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org
Received: (qmail 59435 invoked by uid 500); 1 Jul 2014 18:51:49 -0000
Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@aurora.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@aurora.incubator.apache.org>
List-Post: <mailto:reviews@aurora.incubator.apache.org>
List-Id: <reviews.aurora.incubator.apache.org>
Reply-To: reviews@aurora.incubator.apache.org
Delivered-To: mailing list reviews@aurora.incubator.apache.org
Received: (qmail 59416 invoked by uid 99); 1 Jul 2014 18:51:49 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jul 2014 18:51:49 +0000
X-ASF-Spam-Status: No, hits=-1997.8 required=5.0
	tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Tue, 01 Jul 2014 18:51:48 +0000
Received: (qmail 56389 invoked by uid 99); 1 Jul 2014 18:51:28 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jul 2014 18:51:28 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id DA54B1DB4B9;
	Tue,  1 Jul 2014 18:51:16 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============0632325599111415599=="
MIME-Version: 1.0
Subject: Re: Review Request 23188: Adding getPendingReason RPC to expose
 scheduling
 vetos in the UI/client.
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>
Date: Tue, 01 Jul 2014 18:51:16 -0000
Message-ID: <20140701185116.5196.43831@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
X-ReviewGroup: Aurora
X-ReviewRequest-URL: https://reviews.apache.org/r/23188/
X-Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20140701181439.5201.35092@reviews.apache.org>
In-Reply-To: <20140701181439.5201.35092@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>
X-ReviewRequest-Repository: aurora
X-Virus-Checked: Checked by ClamAV on apache.org

--===============0632325599111415599==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit



> On July 1, 2014, 6:14 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 89
> > <https://reviews.apache.org/r/23188/diff/1/?file=620711#file620711line89>
> >
> >     I much prefer the previous signature.  Why not push the Set->String translation to the call site?
> 
> Maxim Khutornenko wrote:
>     That would require making Veto public, which I did not quite like. Besides, there is only one user of that API and no other use cases that would require a Set<Veto>. I don't quite like String either but that seemed like a reasonable tradeoff given the current semantic. I am ok reverting it if you think Veto can be made public.

Yeah, i don't see much harm in making Veto visible.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/#review47111
-----------------------------------------------------------


On July 1, 2014, 12:28 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23188/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 12:28 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-377
>     https://issues.apache.org/jira/browse/AURORA-377
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java c86f598e2ac226e0a356515b389e76f7c5efb67e 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5d21e5ebe80cda75957475afa9c2b94e202b73b2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java b60b004adbd6753ec6fef125fd70286be5071c56 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b9edd41631b48dd729ec1dafcf0cd20808e9c7c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a746c48dd21a401b84ddcc610d7c99b4f35f8135 
> 
> Diff: https://reviews.apache.org/r/23188/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============0632325599111415599==--