aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Chu-Carroll <mchucarr...@apache.org>
Subject Re: Review Request 23872: Fix problem with deschedule command.
Date Wed, 23 Jul 2014 23:40:29 GMT
It's a bit sneaky - unit tests pass, because they mock the call to the API,
and the way that the API is implemented in Python, the usual spec mechanism
doesn't work for the thrift proxy. So the unit test couldn't catch this.

The end-to-end test should have caught it - I'm not sure why it didn't.
I'll be looking into it.

   -Mark




On Wed, Jul 23, 2014 at 7:37 PM, Bill Farner <wfarner@apache.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23872/
>
> Does this point out lack of unit test coverage, or were unit tests failing?
>
>
> - Bill Farner
>
> On July 23rd, 2014, 11:33 p.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora and Maxim Khutornenko.
> By Mark Chu-Carroll.
>
> *Updated July 23, 2014, 11:33 p.m.*
>  *Bugs: * aurora-597 <https://issues.apache.org/jira/browse/aurora-597>
>  *Repository: * aurora
> Description
>
> Fix problem with deschedule command.
>
>   Diffs
>
>    - src/main/python/apache/aurora/client/api/__init__.py
>    (4e5cce0796d679aa898dde7bee3cee804540c4a9)
>
> View Diff <https://reviews.apache.org/r/23872/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message