aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 24019: Blocking on post drain script call.
Date Thu, 31 Jul 2014 20:06:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49283
-----------------------------------------------------------



src/test/python/apache/aurora/admin/test_admin_util.py
<https://reviews.apache.org/r/24019/#comment86227>

    did we change our import order?
    
    wasn't it
    
    stdlib
    current-projects-namespace
    3rdparty
    ?



src/test/python/apache/aurora/admin/test_admin_util.py
<https://reviews.apache.org/r/24019/#comment86225>

    def test_parse_script



src/test/python/apache/aurora/admin/test_admin_util.py
<https://reviews.apache.org/r/24019/#comment86226>

    def test_parse_script_invalid_filename



src/test/python/apache/aurora/admin/test_admin_util.py
<https://reviews.apache.org/r/24019/#comment86224>

    self.assertRaises[1]
    
    [1] https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises


- Joe Smith


On July 28, 2014, 6:04 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 6:04 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
>     https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/admin_util.py 04eecb7246f02191cd9308c747151e58b203b885

>   src/test/python/apache/aurora/admin/BUILD 20f744b4133ec665e476c00ff46d6b3f8e3add71

>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message