aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.
Date Thu, 31 Jul 2014 19:34:33 GMT


> On July 31, 2014, 7 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/api/updater.py, line 215
> > <https://reviews.apache.org/r/24126/diff/3/?file=646929#file646929line215>
> >
> >     I do not understand this method. The doc comment isn't clear, and the logic
of it doesn't make obvious sense. 
> >     
> >     (1) Under what conditions do you need to wait for the batch to complete? I'm
not sure of what you're trying to capture here.
> >     
> >     (2) This is side-effecting the queues, but the name of it suggests that it's
just a predicate.
> >

This method is called from _wait_for_batch_completion_if_needed() and is gated by the correspondent
UpdateConfig prop check there. The reason this method exists is to make the caller logic a
bit simpler and to isolate the locked content. Reworked a bit to make it clear.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24126/#review49272
-----------------------------------------------------------


On July 31, 2014, 4:38 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24126/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 4:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-626
>     https://issues.apache.org/jira/browse/AURORA-626
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a wait_for_batch_completion option into parallel updater.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/updater.py 05b4c0c76ac2a8551f3aa370ab487f9f0802c3dc

>   src/main/python/apache/aurora/client/api/updater_util.py c5f8f23912701568e1ee6b69186a533fdd29a5d7

>   src/main/python/apache/aurora/config/schema/base.py 3b90ccb33e6ffef9e14befd42d95b8b8a94e949b

>   src/test/python/apache/aurora/client/api/test_updater.py 7020712c9f0b33ec29646482517768ccb13e881f

> 
> Diff: https://reviews.apache.org/r/24126/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message