aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24116: Defining stubs for the Update APIs.
Date Thu, 31 Jul 2014 18:30:27 GMT


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1262
> > <https://reviews.apache.org/r/24116/diff/1/?file=646274#file646274line1262>
> >
> >     Drop a "Not implemented" message in here and it will nicely propagate out through
the API.

Done.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 504
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line504>
> >
> >     Please doc this, and fields within.  Ditto elsewhere.

Done.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 513
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line513>
> >
> >     Here's the enum i've sketched out in my branch, how do you feel about these
instead?
> >     
> >       enum Status {
> >         INIT,
> >         ROLLING_FORWARD,
> >         ROLLING_BACK,
> >         ROLL_FORWARD_PAUSED,
> >         ROLL_BACK_PAUSED,
> >         ROLLED_FORWARD,
> >         ROLLED_BACK,
> >         ABORTED,
> >         ERROR
> >       }

Changed.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 525
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line525>
> >
> >     Why does an update need to know the starting state?  Shouldn't this be gleaned
from the Update immediately before it?

Dropped Update object completely.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 526
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line526>
> >
> >     Shouldn't this be a TaskConfig?

Yup.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 528
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line528>
> >
> >     startTimestampMs?

Dropped.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 529
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line529>
> >
> >     endTimestampMs?

Dropped.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 582
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line582>
> >
> >     This should contain update events, and explicitly not the Update.  Can you define
a half-baked UpdateEvent struct?  Just an instance ID and timestamp should be fine for now,
along with a TODO.

There is now UpdateEvent with a collection of UpdateInstanceEvents.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 688
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line688>
> >
> >     Add a note about being not yet implemented here, for nice presentation in the
auto-generated help pages.

Done.


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 692
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line692>
> >
> >     How would you feel about generalizing this to support more use cases, like getting
all in-progress updates?  You could accept more parameters for this:
> >     
> >     Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status)
> 
> Maxim Khutornenko wrote:
>     Not sure I like it. What should be the output if all 3 are provided?
>     
>     How about something like UpdateQuery instead (similar to TaskQuery)?

Taken the UpdateQuery-based approach.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49168
-----------------------------------------------------------


On July 31, 2014, 6:27 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24116/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 6:27 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-611
>     https://issues.apache.org/jira/browse/AURORA-611
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First stab at update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2

>   src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10

> 
> Diff: https://reviews.apache.org/r/24116/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message