aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24116: Defining stubs for the Update APIs.
Date Thu, 31 Jul 2014 16:03:40 GMT


> On July 30, 2014, 9:36 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 692
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line692>
> >
> >     How would you feel about generalizing this to support more use cases, like getting
all in-progress updates?  You could accept more parameters for this:
> >     
> >     Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status)

Not sure I like it. What should be the output if all 3 are provided?

How about something like UpdateQuery instead (similar to TaskQuery)?


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49168
-----------------------------------------------------------


On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24116/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 9:12 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-611
>     https://issues.apache.org/jira/browse/AURORA-611
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First stab at update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2

>   src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10

> 
> Diff: https://reviews.apache.org/r/24116/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message