aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 24116: Defining stubs for the Update APIs.
Date Thu, 31 Jul 2014 15:59:54 GMT


> On July 30, 2014, 9:35 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1251
> > <https://reviews.apache.org/r/24116/diff/1/?file=646274#file646274line1251>
> >
> >     Why is the previous JobConfiguration needed to do an update?

Good point. The only reason it's there to provide cron job details but that's handled by a
separate set of APIs.


> On July 30, 2014, 9:35 p.m., David McLaughlin wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 529
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line529>
> >
> >     Does it need an updated timestamp for pauses, etc.?

I am not even sure we need either of these timestamps here. If we rely on UpdateEvents to
tell the story these timestamps should be dropped. 


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49170
-----------------------------------------------------------


On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24116/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 9:12 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-611
>     https://issues.apache.org/jira/browse/AURORA-611
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First stab at update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2

>   src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10

> 
> Diff: https://reviews.apache.org/r/24116/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message