aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
Date Tue, 29 Jul 2014 23:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24059/
-----------------------------------------------------------

(Updated July 29, 2014, 11:58 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

Rebased on master.


Bugs: AURORA-606
    https://issues.apache.org/jira/browse/AURORA-606


Repository: aurora


Description
-------

This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general
improvement in how we interact with jetty.  I've left a TODO for the next step (simplify addition
of static assets).

The only expected functional change is the removal of /pprof/*, which i have not found to
produce useful output in practice (at least, not as useful as other standard JVM tools).

I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we
no longer appear to use anywhere.


[1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java


Diffs (updated)
-----

  build.gradle 22ac38662a19a09374f731c2493ed64740267b79 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b

  src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 5c0fc2c36ba67e8701288ac5d678eea28aba6528

  src/test/java/org/apache/aurora/scheduler/http/MnameTest.java b7b6a3e32f02b77da6f83ab891ff90b1992faa95

  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 0399ec0fe40a7f2057ac59a7fe5fb2583e93ded3

  src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 63c504ed1f863cd7294d572766ef4eebd1d5d313

  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 0bcc015977ee475954172c461306844f77eb13af


Diff: https://reviews.apache.org/r/24059/diff/


Testing
-------

./gradlew clean build -Pq

bash examples/vagrant/test_tutorial.sh

Manually clicked around in a local scheduler.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message