aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation
Date Thu, 24 Jul 2014 01:05:44 GMT


> On July 23, 2014, 5:40 p.m., Kevin Sweeney wrote:
> > Good start, thanks for getting this out here. Any thoughts on wiring up executor
command-line flags as a scheduler command-line flag? Should make this relatively easy to wire
up, demo, and integration test. Worth a followup review?
> 
> Bill Farner wrote:
>     I like Brian's suggestion to use a shim script instead.  My sense is that this gives
the end-user the most flexibility.

We should be mindful to preserve flexibility in executor deploys. Right now you can (for example)
supply a url to the scheduler as the executor_path and mesos will fetch it for you. For public
clouds it's feasible there's a well-known stable executor url that needs some (global per-cluster)
configuration (zk ensemble for example). Letting the user configure that on the scheduler
command-line frees them from needing to arrange for a special executor shim script somewhere
every node in the cluster can see.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------


On July 23, 2014, 1:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 1:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-587
>     https://issues.apache.org/jira/browse/AURORA-587
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common.
 Open to suggestions about wiring up -- right now it is enabled via command line flags, but
we don't have prior art for invoking the executor with command line flags (I think the scheduler
just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin
shell wrapper around the executor.pex.)  We can alternately switch to entry_points style a
la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin,
but would require a separate review.  Open to ideas.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c

>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e

>   src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c

>   src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b

>   src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23863/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message