aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 23835: Refactoring SchedulerCore (forceTaskState)
Date Wed, 23 Jul 2014 20:23:56 GMT


> On July 23, 2014, 3:09 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 880
> > <https://reviews.apache.org/r/23835/diff/1/?file=640398#file640398line880>
> >
> >     You could address this TODO now by tagging the method with @Requires.  If you'd
rather that be teased out of that review, please s/Sathya/wfarner/

That would not work as context is accessed later to extract user identity in:

  transitionMessage(context.getIdentity()));


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23835/#review48471
-----------------------------------------------------------


On July 23, 2014, 2:33 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23835/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 2:33 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-94
>     https://issues.apache.org/jira/browse/AURORA-94
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moving forceTaskState from SchedulerCore into SchedulerThriftInterface.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 137bd6ccafc48508ccd48004e7111fe69449152d

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java adc2dbc8c451260e8e4749dd07f47e1b0cd7dda2

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f94e0447066a2e9f2e460a284c7f93eac347a91

>   src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 5ec7cf395080cd593a5d5291eff835f89c65dac2

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d3ac7c7585e8fcac6d26f06f53c9101aa9787808 
> 
> Diff: https://reviews.apache.org/r/23835/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message