aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 23244: Fixing return value in _check_sla.
Date Tue, 22 Jul 2014 20:40:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23244/
-----------------------------------------------------------

(Updated July 22, 2014, 8:40 p.m.)


Review request for Aurora, Joe Smith and Mark Chu-Carroll.


Changes
-------

CR comments.


Bugs: AURORA-571
    https://issues.apache.org/jira/browse/AURORA-571


Repository: aurora


Description
-------

Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to help troubleshooting
occasional LOST tasks when draining.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java bf48db97cf882105c0b2e6b70f9a4612ce60dbe8

  src/main/python/apache/aurora/admin/host_maintenance.py b5b1375b1bbaed833acf2d17ec432b3d99145fab

  src/test/python/apache/aurora/client/commands/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f


Diff: https://reviews.apache.org/r/23244/diff/


Testing
-------

gradle -Pq build
./pants src/test/python:all


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message