aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 23244: Fixing return value in _check_sla.
Date Tue, 22 Jul 2014 20:03:19 GMT


> On July 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 131
> > <https://reviews.apache.org/r/23244/diff/2/?file=639321#file639321line131>
> >
> >     What is this initialization doing? I don't see what it changes - it's reassigned
just below, in code which executes unconditionally.
> >

Ah, that's the actual bug I fixed. In case the inner IF block does not return, the control
falls through to the method return statement, which blows with "'unsafe_hostnames' is not
defined" error.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23244/#review48415
-----------------------------------------------------------


On July 22, 2014, 4:41 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23244/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 4:41 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-571
>     https://issues.apache.org/jira/browse/AURORA-571
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to help troubleshooting
occasional LOST tasks when draining.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java bf48db97cf882105c0b2e6b70f9a4612ce60dbe8

>   src/main/python/apache/aurora/admin/host_maintenance.py b5b1375b1bbaed833acf2d17ec432b3d99145fab

>   src/test/python/apache/aurora/client/commands/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f

> 
> Diff: https://reviews.apache.org/r/23244/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message