aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.
Date Tue, 22 Jul 2014 14:33:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48362
-----------------------------------------------------------



src/main/python/apache/aurora/client/commands/core.py
<https://reviews.apache.org/r/23455/#comment84911>

    Yeah, I know - but I think that it's clearer. Probably just me, but I find that skimming
code, I look for something in the body of a function, and I misread subsequent code as being
nested functions if the explicit pass is omitted.


- Mark Chu-Carroll


On July 14, 2014, 1:50 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23455/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 1:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-581
>     https://issues.apache.org/jira/browse/aurora-581
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a lightweight version of command hooks for clientv1 commands.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d

>   src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b

> 
> Diff: https://reviews.apache.org/r/23455/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests, and ran full unit test suite.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message