aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers
Date Mon, 21 Jul 2014 16:47:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23718/#review48248
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/BUILD
<https://reviews.apache.org/r/23718/#comment84596>

    I believe this file can be deleted, i don't know of any reason for empty BUILD files to
exist.


- Bill Farner


On July 20, 2014, 8:07 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23718/
> -----------------------------------------------------------
> 
> (Updated July 20, 2014, 8:07 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-594
>     https://issues.apache.org/jira/browse/AURORA-594
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-594: RC1 files missing Apache license headers
> 
> Adds missing license headers to empty and newly added files.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/BUILD e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/test/python/apache/aurora/client/cli/AuroraHooks c25bcfba2a3f58523769b966576f95809d7ebb26

>   src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 6333986e9afe5b0068bfdcc9a2b3f4cb5dd03578

>   src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 768c124aeb8bb47986312ec70641ad9d09f0913b

> 
> Diff: https://reviews.apache.org/r/23718/diff/
> 
> 
> Testing
> -------
> 
> ran: build-support/jenkins/build.sh
> 
> All test passed except test_cluster_option as outlined in AURORA-595
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message