aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.
Date Mon, 21 Jul 2014 16:45:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23741/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
-------

In this change, i've added two outputs from thrift_wrapper_codegen.py:
- A service metadata file (java) that maps RPC method names to parameter and type information
- A series of html documents that describes methods and types used in the API (drawing from
javadoc-style comments in api.thrift)

ApiBeta.java consumes the metadata file, and uses it to instruct gson how to deserialize incoming
requests.  It in turn uses reflection to invoke the appropriate method on the thrift interface
implementation.


Diffs
-----

  build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 27599f75603542069084631baf9195b8ad75e902

  src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java PRE-CREATION 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 9d500baf82914733c0f92752d9570da009870aa9

  src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad


Diff: https://reviews.apache.org/r/23741/diff/


Testing
-------

Manual only, will post some snippets shortly.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message