aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 23329: remove embedded jquery
Date Tue, 08 Jul 2014 01:18:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23329/#review47428
-----------------------------------------------------------



src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl
<https://reviews.apache.org/r/23329/#comment83209>

    -1, this is pretty much unacceptable from a security standpoint - data visible to the
observer origin includes sensitive application logs
    
    -1 from a reliability standpoint as well - the observer is used to debug low-level infrastructure
and a dependency on an external CDN doesn't work for that.


- Kevin Sweeney


On July 7, 2014, 6:08 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23329/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 6:08 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-578
>     https://issues.apache.org/jira/browse/AURORA-578
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> remove embedded jquery
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/jquery.js 3774ff986139c8a7534e14bc8987fe80418dcc1b

>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4

>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88

>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c

> 
> Diff: https://reviews.apache.org/r/23329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message