aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 23211: Fix TaskObserver for json endpoint usage
Date Tue, 01 Jul 2014 20:54:58 GMT


> On July 1, 2014, 8:51 p.m., Kevin Sweeney wrote:
> > Hi Kevin,
> > 
> > Can you please rebase this patch against master.
> > 
> > Thanks,
> > Kevin
> 
> Kevin Sweeney wrote:
>     (You can preview the diff that will be sent with ./rbt patch or by using the draft
feature.)

Sorry about that, i just snuck in a commit since you posted the pull request :-/


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23211/#review47141
-----------------------------------------------------------


On July 1, 2014, 8:46 p.m., Kevin Burg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23211/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 8:46 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix TaskObserver for json endpoint usage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d

>   src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f

>   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673

>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df

>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3

>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223

>   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac

>   src/main/java/org/apache/aurora/scheduler/TaskVars.java a58696ba094619ca130c4b8f5287696856d7c1e7

>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815

>   src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7

>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2

>   src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711

>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5

>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628

>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f

>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a

>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4

>   src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef

>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916

>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923

>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9

>   src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java d29fbd4f9a3d7fe813f2f105669cf63322efe758

>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 71620d70a5bd7c6c309281c3e59bc53f04af781b

>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 860a240a6d185ce8fa63ca6e0525219794c9c865

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java a336b47a652965fa76d65bb8eb415d6d5bd26982

>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 070c7da75a1d4f8541ec26880b4bdcb0e75255aa

>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 051166cdad402b00542167ff15a00a578ee5d07e

>   src/main/java/org/apache/aurora/scheduler/http/Locks.java dce1891e0477773e254932d7434248281c40f753

>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 5470e6fa2a39db8a75993d23ef8384443d131846

>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 88dd23c008aa49f51426ce8d791e61a45d69e210

>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 19add3524745afcb5c520c5c8b5fd6bda7068ce0

>   src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java fea52f761b094e4edd02ad1a8fa2115afd3c31bc

>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java f23739a38d5abe69c350da3f8ca725e555fa9c89

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java fb225f185c97f45aa60b870295ef8c8532fdb143

>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java bbbdb92423447c4219ed40731271739390a0741c

>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java a7fbcbf6707eab7867ee71c1d25717298488dfca

>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java d6dfcf11990c10c5861d58eb6b028db6569a50f5

>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 31cfc8ca1aa9a2a1e9d582063a6289e94fa6dbd4

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java ee6149cce6bee1f8389ac66d894b443630f7eaec

>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java f73b5eb4c0f5fc4d30daa8e3a2f7bc71ea274947

>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java b2cfba63e710cab85eea08a69e8079182fe7f1aa

>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java 0580c40a41a1263791a77c16df7ecdf7dce898ea

>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java c86f598e2ac226e0a356515b389e76f7c5efb67e

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 1a7b42124fceca80fb4fcde94b1c5a3eb602ef19

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d349c5fde96cc60d0d9c4c96149b29c2a0c7b447

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 7aedea5948b1ef1a7cd498615b65ecbb6e77c089

>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java bce5f4e2648eb78c4b0eb3eb85c2441e42c1614e

>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860

>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java ec953e1d80642de3d06978199aa5a4560d9a9e6f

>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java df2bc5a42d0ec011f0c19c606e962ad871c28182

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 0c3e1fb38293e46eb62fd7c52b81a73cd52c94fb

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 44ced61db75378043d6ff023878fb962221d4579

>   src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f

>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 7f27a1fe8f9e0bc3831e631154df555e2a3d8a7d

>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 2dc2d8cc812ba2e9815f7f69b3a4112075080b6a

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 6e0aa13ea368040dcdc93b4055b08299d2155672

>   src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 3b5c61713f8b4a9f921e49ce12abbfd0bb28089f

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java e72bc48c64e52679b43f258db39bd07d4ddd04cd

>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java af99957892fa0ff24e9d07896f3a417860be2021

>   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 557c2131a12ccc2a20e0fa42f8355ac87ac9fa73

>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 0a0650e66ae37d0ebd4ce08ba5ace1dd47ef336c

>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java e23506b7a3546c896f3095c80e3a20a97bee77d3

>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 37255904a4f429293f933909829f43b6ffe696ea

>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 4e2fb8be3ddfdb5a264b93a286f76dd6c8e06ca3

>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java f1511b8c1f3e5798a8832a3b642693185aed7e1c

>   src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 8bc0b8c0510d083aec359fa648b474bd8207e25c

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 0e7f52c83fb450f631751a635fd4d85fc61e3bab

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 1738b95cd67cf990bd8aad8c744a1febe2d87f15

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 0c327de205e95fea1fda03c14c824e0e6c299a56

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c683e398640c7ebf2047ef308a701cb4897c58dc

>   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 72543bf833e40944510657233ed405f2076d7695

>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 505c94d6800c1453b1b1f696ef774f5943973f19

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 496f13ee26b4f9cf45934478de0e688e776e68b5

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 2d7e81cf2744f2f9a2b0053121e096193528dd97

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 083e3ffa9add639666c2a3bcad478678886c643f

>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 4257cb9f27e96a09d11aedd195f89accd9395364

>   src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 35e2e5ab0fb4740ff06b50f35177dbd47ff66779

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java 571636d80ab63a2fef2398387070acd8f1f6d9b1

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 65750b61b864f0e830513039a7c9d727ac9d493d

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 23555c2483d7fe716243847f8478898e98fb5ac4

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 3d3dcb1d5bdb472c1f2f77850f46d1e288acd2b1

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5751a86af2d9643bc6988e400fcf4a388ff75c51

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
411efeaedda72f68e90f60720328d83b5d30fb16 
>   src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java a78e6669a0a9b4ef578c4ce8b436f376f4e338c3

>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 13e346154536e029b813496acc403020f6ef8384

>   src/main/python/apache/thermos/observer/task_observer.py b2114db1173ab52cc5c9ef41a53012d9a9b99cc7

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 2e128f49173a69bb09dee32e8dbac27e5d3b1021

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 6dcf695a0890fc73f7060b581068e5170fadf39e

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java 4376983403dfd2024ae88410e256599e3ed81525

>   src/test/java/org/apache/aurora/scheduler/http/LocksTest.java 603851460be1e32731129a24ef2edf58d376a29d

>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 7bbc99b344550b5c054efcf86bf14e4edc600e6b

>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java e8b6241f95bcff6d9bb35e2c224d9aa234871c6b

>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java f1892bd91214fc9d4c58d1117936395fa4b96ae8

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java a746c48dd21a401b84ddcc610d7c99b4f35f8135

> 
> Diff: https://reviews.apache.org/r/23211/diff/
> 
> 
> Testing
> -------
> 
> The `/j/task?task_id=id1,id2,...` endpoint now works.
> 
> 
> Thanks,
> 
> Kevin Burg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message