aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 23180: Export a stat to track number of LOST gc_executors
Date Tue, 01 Jul 2014 18:43:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47121
-----------------------------------------------------------


Build failed with this patch.  Please try running ./gradlew build -Pq, and fix.

:compileTestJava
/home/wfarner/code/aurora/src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java:215:
warning: [static] static method should be qualified by type name, GcExecutorLauncher, instead
of by an expression
    TaskInfo task = gcExecutorLauncher.makeGcTask(HOST, OFFER.getSlaveId(), SETTINGS.getGcExecutorPath().get(),
TASK_UUID, message);
                                      ^
error: warnings found and -Werror specified
1 error
1 warning
:compileTestJava FAILED



- Bill Farner


On June 30, 2014, 11:12 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23180/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 11:12 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-562
>     https://issues.apache.org/jira/browse/AURORA-562
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Track the number of LOST gc_executors
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2

>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb

> 
> Diff: https://reviews.apache.org/r/23180/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew test
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message