aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)
Date Tue, 01 Jul 2014 17:55:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23199/#review47106
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/23199/#comment82712>

    This doesn't play nicely with the include() directive, which may load other config files
from elsewhere. It also introduces a race (you open and close the config file here, then the
loader presumably does as well meaning that the file contents could change after you've logged
them). I wonder if this logic would be better pushed down to the loader.



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/23199/#comment82711>

    Add a constant for the TRANSCRIPT loglevel somewhere?


- Kevin Sweeney


On July 1, 2014, 8:03 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23199/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 8:03 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: aurora-567
>     https://issues.apache.org/jira/browse/aurora-567
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Have client commands that load config files print the contents of the loaded config file
to 
> log at level TRANSCRIPT (aka INFO+1).
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py facd52c14e330c35889cec0292bb380cecff9641

>   src/test/python/apache/aurora/client/cli/test_logging.py b3c3b8deaa8961251a1be8121659e742b00f6df2

> 
> Diff: https://reviews.apache.org/r/23199/diff/
> 
> 
> Testing
> -------
> 
> Added unit test of new functionality, ran all tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message