Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2526262825079502712=="
MIME-Version: 1.0
Subject: Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
From: "Kevin Sweeney" <kevints@apache.org>
To: "Bill Farner" <wfarner@apache.org>,
 "Dave Lester" <dave@ischool.berkeley.edu>,
 "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Jake Farrell" <jfarrell@apache.org>
Date: Fri, 27 Jun 2014 18:00:19 -0000
Message-ID: <20140627180019.22595.77722@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Kevin Sweeney" <noreply@reviews.apache.org>
References: <20140625210738.22595.95489@reviews.apache.org>
In-Reply-To: <20140625210738.22595.95489@reviews.apache.org>
Reply-To: "Kevin Sweeney" <kevints@apache.org>

--===============2526262825079502712==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On June 25, 2014, 2:07 p.m., Bill Farner wrote:
> > .gitattributes, line 3
> > <https://reviews.apache.org/r/22983/diff/1/?file=617565#file617565line3>
> >
> >     IIUC this will render a source distribution unusable, since many necessary files will be missing.
> 
> Jake Farrell wrote:
>     if i'm not mistaken /src/resources is only used for the e2e test, we need to come up with a way to auto generate those files if possible as they can not be included in the src release
> 
> Bill Farner wrote:
>     Aha, my mistake - i was thinking of src/main/resources, this is src/resources, which is used by the python build.  Filed https://issues.apache.org/jira/browse/AURORA-559 to put those in a conventional path.

src/resources is all test data for the executor. the binary files in here are tbinaryprotocol-serialized data used to test the executor's mechanism for communicating between processes. if we remove it then those tests will fail in the source distribution, which would mean a -1 to shipping.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22983/#review46679
-----------------------------------------------------------


On June 25, 2014, 1:18 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22983/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 1:18 p.m.)
> 
> 
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-278
>     https://issues.apache.org/jira/browse/AURORA-278
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-278 - Remove binaries from source RC
> 
> 
> Diffs
> -----
> 
>   .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea 
>   .gitattributes PRE-CREATION 
>   CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7 
>   build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb 
>   build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947 
>   build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db 
> 
> Diff: https://reviews.apache.org/r/22983/diff/
> 
> 
> Testing
> -------
> 
> ./builds-support/release/release-candidate -r 1 -l m
> 
> verified gig sig, md5, sha, untared release and looked for binary artifacts.
> 
> Additional review opened to address missing headers
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


--===============2526262825079502712==--