Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67AE01121E for ; Wed, 25 Jun 2014 18:48:58 +0000 (UTC) Received: (qmail 27078 invoked by uid 500); 25 Jun 2014 18:48:58 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 27039 invoked by uid 500); 25 Jun 2014 18:48:58 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 27028 invoked by uid 99); 25 Jun 2014 18:48:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 18:48:58 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 25 Jun 2014 18:48:56 +0000 Received: (qmail 25313 invoked by uid 99); 25 Jun 2014 18:48:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 18:48:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1DCF71DB293; Wed, 25 Jun 2014 18:48:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7640953205743826529==" MIME-Version: 1.0 Subject: Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group. From: "Maxim Khutornenko" To: "Joe Smith" , "David McLaughlin" Cc: "Aurora" , "Maxim Khutornenko" Date: Wed, 25 Jun 2014 18:48:26 -0000 Message-ID: <20140625184826.22595.45361@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22842/ X-Sender: "Maxim Khutornenko" References: <20140620214006.6311.43295@reviews.apache.org> In-Reply-To: <20140620214006.6311.43295@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7640953205743826529== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ ----------------------------------------------------------- (Updated June 25, 2014, 6:48 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Changes ------- CR comments. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description ------- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs (updated) ----- src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing ------- ./pants src/test/python:all Thanks, Maxim Khutornenko --===============7640953205743826529==--