Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A08311D26 for ; Thu, 19 Jun 2014 22:06:47 +0000 (UTC) Received: (qmail 29805 invoked by uid 500); 19 Jun 2014 22:06:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 29760 invoked by uid 500); 19 Jun 2014 22:06:41 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 29749 invoked by uid 99); 19 Jun 2014 22:06:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2014 22:06:40 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Jun 2014 22:06:39 +0000 Received: (qmail 29671 invoked by uid 99); 19 Jun 2014 22:06:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2014 22:06:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6A41D1DB0CA; Thu, 19 Jun 2014 22:06:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4897127588336322416==" MIME-Version: 1.0 Subject: Re: Review Request 22792: Add test coverage for MesosLog. From: "Bill Farner" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora" Date: Thu, 19 Jun 2014 22:06:09 -0000 Message-ID: <20140619220609.13794.74053@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22792/ X-Sender: "Bill Farner" References: <20140619213823.13794.45788@reviews.apache.org> In-Reply-To: <20140619213823.13794.45788@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4897127588336322416== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22792/ ----------------------------------------------------------- (Updated June 19, 2014, 10:06 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description ------- This brings instruction coverage to 86% in MesosLog, 81% overall. Unfortunately in this effort i learned of a shortcoming in jacoco, described here: http://www.eclemma.org/jacoco/trunk/doc/faq.html > Code with exceptions shows no coverage. Why? > JaCoCo determines code execution with so called probes. Probes are inserted into the control flow at certain positions. > Code is considered as executed when a subsequent probe has been executed. In case of exceptions such a sequence of > instructions is aborted somewhere in the middle and not marked as executed. http://bryanpendleton.blogspot.com/2012/07/java-code-coverage-and-thrown.html This issue prevents us from achieving 100% coverage in MesosLog, and will do so in other classes that throw exceptions. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java b8a94ff90dfcb4d18a79ae3d60fc8384eebf590f src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 23c1d7a4190c58912d99009ae75bdd87488cd688 Diff: https://reviews.apache.org/r/22792/diff/ Testing ------- ./gradlew build -Pq Thanks, Bill Farner --===============4897127588336322416==--