Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============7429224567544992536=="
MIME-Version: 1.0
Subject: Re: Review Request 22792: Add test coverage for MesosLog.
From: "Maxim Khutornenko" <maxim@apache.org>
To: "Maxim Khutornenko" <maxim@apache.org>
Cc: "Bill Farner" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>
Date: Thu, 19 Jun 2014 21:50:41 -0000
Message-ID: <20140619215041.6311.60255@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Maxim Khutornenko" <noreply@reviews.apache.org>
References: <20140619213823.13794.45788@reviews.apache.org>
In-Reply-To: <20140619213823.13794.45788@reviews.apache.org>
Reply-To: "Maxim Khutornenko" <maxim@apache.org>

--===============7429224567544992536==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22792/#review46230
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On June 19, 2014, 9:38 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22792/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This brings instruction coverage to 86% in MesosLog, 81% overall.  Unfortunately in this effort i learned of a shortcoming in jacoco, described here: 
> 
> http://www.eclemma.org/jacoco/trunk/doc/faq.html
> > Code with exceptions shows no coverage. Why?
> 
> > JaCoCo determines code execution with so called probes. Probes are inserted into the control flow at certain positions.
> > Code is considered as executed when a subsequent probe has been executed. In case of exceptions such a sequence of
> > instructions is aborted somewhere in the middle and not marked as executed.
> 
> http://bryanpendleton.blogspot.com/2012/07/java-code-coverage-and-thrown.html
> 
> This issue prevents us from achieving 100% coverage in MesosLog, and will do so in other classes that throw exceptions.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java b8a94ff90dfcb4d18a79ae3d60fc8384eebf590f 
>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 23c1d7a4190c58912d99009ae75bdd87488cd688 
> 
> Diff: https://reviews.apache.org/r/22792/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


--===============7429224567544992536==--