Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40F2B1160B for ; Wed, 18 Jun 2014 15:00:04 +0000 (UTC) Received: (qmail 79361 invoked by uid 500); 18 Jun 2014 15:00:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 79335 invoked by uid 500); 18 Jun 2014 15:00:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 79324 invoked by uid 99); 18 Jun 2014 15:00:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2014 15:00:03 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Jun 2014 15:00:04 +0000 Received: (qmail 78848 invoked by uid 99); 18 Jun 2014 14:59:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2014 14:59:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B6CF41C4519; Wed, 18 Jun 2014 14:59:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8913423530869594566==" MIME-Version: 1.0 Subject: Re: Review Request 22457: Improve aurora "job diff" command. From: "Mark Chu-Carroll" To: "Brian Wickman" , "David McLaughlin" Cc: "Joe Smith" , "Aurora" , "Mark Chu-Carroll" , "Kevin Sweeney" , "Maxim Khutornenko" Date: Wed, 18 Jun 2014 14:59:28 -0000 Message-ID: <20140618145928.13794.15235@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22457/ X-Sender: "Mark Chu-Carroll" References: <20140613202258.22324.91011@reviews.apache.org> In-Reply-To: <20140613202258.22324.91011@reviews.apache.org> Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8913423530869594566== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ ----------------------------------------------------------- (Updated June 18, 2014, 10:59 a.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Changes ------- Reviews. Bugs: aurora-520 https://issues.apache.org/jira/browse/aurora-520 Repository: aurora Description ------- Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running job configurations to potentially updated configs. - Allow exclusion of semantically irrelevant fields. - Provide a clearer list of the differences between configs. - Provide a scripting-friendly alternative JSON syntax for diffs. The old diff behavior is still available under the "--use-shell-diff" option. Diffs (updated) ----- src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565 src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/22457/diff/ Testing ------- New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests of the new functionality. All tests pass. Thanks, Mark Chu-Carroll --===============8913423530869594566==--