Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8240911135874783570=="
MIME-Version: 1.0
Subject: Re: Review Request 22457: Improve aurora "job diff" command.
From: "Joe Smith" <yasumoto7@gmail.com>
To: "Brian Wickman" <wickman@apache.org>,
 "David McLaughlin" <david@dmclaughlin.com>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Joe Smith" <yasumoto7@gmail.com>,
 "Mark Chu-Carroll" <mchucarroll@twopensource.com>
Date: Fri, 13 Jun 2014 19:24:17 -0000
Message-ID: <20140613192417.22323.98906@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Joe Smith" <noreply@reviews.apache.org>
References: <20140611150050.22322.19677@reviews.apache.org>
In-Reply-To: <20140611150050.22322.19677@reviews.apache.org>
Reply-To: "Joe Smith" <yasumoto7@gmail.com>

--===============8240911135874783570==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review45635
-----------------------------------------------------------


cool, lgtm


src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/22457/#comment80532>

    It's probably worthy- otherwise how else is a user going to see it?


src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/22457/#comment80533>

    "the output of DIFF_VIEWER or unix diff" maybe?


src/main/python/apache/aurora/client/cli/json_tree_diff.py
<https://reviews.apache.org/r/22457/#comment80539>

    is this actually called somewhere?
    
    (and I promise I tried to understand what this is doing, but I can't ~_~)
    
    (what does 'rebase' mean?)


- Joe Smith


On June 11, 2014, 8 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22457/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 8 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-520
>     https://issues.apache.org/jira/browse/aurora-520
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running job configurations to potentially updated configs.
> 
> - Allow exclusion of semantically irrelevant fields.
> - Provide a clearer list of the differences between configs.
> - Provide a scripting-friendly alternative JSON syntax for diffs.
> 
> The old diff behavior is still available under the "--use-shell-diff" option.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
>   src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565 
>   src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 
>   src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 
>   src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22457/diff/
> 
> 
> Testing
> -------
> 
> New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests of the new functionality.
> All tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


--===============8240911135874783570==--