Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 967A210AC4 for ; Wed, 4 Jun 2014 21:09:28 +0000 (UTC) Received: (qmail 16265 invoked by uid 500); 4 Jun 2014 21:09:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 16227 invoked by uid 500); 4 Jun 2014 21:09:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 16217 invoked by uid 99); 4 Jun 2014 21:09:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2014 21:09:28 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 04 Jun 2014 21:09:28 +0000 Received: (qmail 14053 invoked by uid 99); 4 Jun 2014 21:09:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2014 21:09:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19A111D9B0C; Wed, 4 Jun 2014 21:08:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2299520926770447734==" MIME-Version: 1.0 Subject: Re: Review Request 22233: Fix logging in the command-runner. From: "Brian Wickman" To: "Brian Wickman" , "David McLaughlin" Cc: "Aurora" , "Mark Chu-Carroll" Date: Wed, 04 Jun 2014 21:08:53 -0000 Message-ID: <20140604210853.12450.1985@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22233/ X-Sender: "Brian Wickman" References: <20140604170915.12450.31407@reviews.apache.org> In-Reply-To: <20140604170915.12450.31407@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2299520926770447734== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22233/#review44757 ----------------------------------------------------------- Ship it! Ship It! - Brian Wickman On June 4, 2014, 5:09 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22233/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 5:09 p.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Bugs: aurora-503 > https://issues.apache.org/jira/browse/aurora-503 > > > Repository: aurora > > > Description > ------- > > Fix logging in the command-runner. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540 > src/main/python/apache/aurora/client/api/command_runner.py 8b29f35f85f4173158e0d46aba091915bf7200d0 > src/main/python/apache/aurora/client/cli/client.py 1fb5364894d230646592942434eb1da6554d5c05 > src/main/python/apache/aurora/client/cli/config.py 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122 > src/main/python/apache/aurora/client/cli/cron.py c30a0a605412229f3e4cddbe8c5ae746f256e30c > src/main/python/apache/aurora/client/cli/task.py fe11f38b902ae54a4048ba114055ba30e8abe6c5 > src/test/python/apache/aurora/client/api/test_sla.py 9c3bb6d386abbdbbfa8746639798ddca01d54fe9 > src/test/python/apache/aurora/client/cli/test_config_noun.py 7a9d733835e204bfd179e698bc335435b837d24b > src/test/python/apache/aurora/client/cli/test_cron.py 049405a4323fc73102d6ac1dae2230be4325c530 > src/test/python/apache/aurora/client/cli/test_task_run.py 26633981d561eeed498acece03c025bec00e11bd > src/test/python/apache/aurora/client/test_config.py 4b3e1499c7447792288f4b480cbd756c8e19a831 > src/test/sh/org/apache/aurora/e2e/http_example.py 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66 > > Diff: https://reviews.apache.org/r/22233/diff/ > > > Testing > ------- > > Added check to unit tests; all client tests pass. > > > Thanks, > > Mark Chu-Carroll > > --===============2299520926770447734==--