aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Chu-Carroll <mchucarr...@apache.org>
Subject Re: Review Request 22457: Improve aurora "job diff" command.
Date Mon, 30 Jun 2014 12:06:44 GMT
wickman, ping?


On Fri, Jun 27, 2014 at 11:25 AM, Maxim Khutornenko <maxim@apache.org>
wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22457/
>
> Ship it!
>
> Ship It!
>
>
> - Maxim Khutornenko
>
> On June 27th, 2014, 2:41 p.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated June 27, 2014, 2:41 p.m.*
>  *Bugs: * aurora-520 <https://issues.apache.org/jira/browse/aurora-520>
>  *Repository: * aurora
> Description
>
> Add a new diff method, which uses field-by-field comparison of JSON trees for comparing
running job configurations to potentially updated configs.
>
> - Allow exclusion of semantically irrelevant fields.
> - Provide a clearer list of the differences between configs.
> - Provide a scripting-friendly alternative JSON syntax for diffs.
>
> The old diff behavior is still available under the "--use-shell-diff" option.
>
>   Testing
>
> New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests of the
new functionality.
> All tests pass.
>
>   Diffs
>
>    - src/main/python/apache/aurora/client/cli/BUILD
>    (ebe681a0d1735b7cc695dc3b7a14c4292d87ae32)
>    - src/main/python/apache/aurora/client/cli/jobs.py
>    (4fa03a6c9919651551238b0dc211ed69a8dfe565)
>    - src/main/python/apache/aurora/client/cli/json_tree_diff.py
>    (PRE-CREATION)
>    - src/test/python/apache/aurora/client/cli/BUILD
>    (3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378)
>    - src/test/python/apache/aurora/client/cli/test_diff.py
>    (38629b63c082cf81cb891dace2a70d9e8f418e18)
>    - src/test/python/apache/aurora/client/cli/test_json_diff.py
>    (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/22457/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message