aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
Date Thu, 26 Jun 2014 19:14:45 GMT


> On June 26, 2014, 6:21 p.m., Kevin Sweeney wrote:
> > replace Preconditions.checkNotNull with Objects.requireNonNull as well?

Great suggestion, i'll update the diff to add that.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22982/#review46770
-----------------------------------------------------------


On June 25, 2014, 7:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22982/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use java.util.Objects replacements for guava helpers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92

>   src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8

>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916

>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6

>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860

>   src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f

>   src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab

> 
> Diff: https://reviews.apache.org/r/22982/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message