aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Date Mon, 23 Jun 2014 22:37:28 GMT


> On June 23, 2014, 10:21 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 436
> > <https://reviews.apache.org/r/22429/diff/4/?file=613082#file613082line436>
> >
> >     redundant with the line below

Removed.


> On June 23, 2014, 10:21 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 239
> > <https://reviews.apache.org/r/22429/diff/4/?file=613083#file613083line239>
> >
> >     remove extra newline

Done.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46464
-----------------------------------------------------------


On June 23, 2014, 10:36 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 10:36 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
> 
> 
> Bugs: AURORA-519
>     https://issues.apache.org/jira/browse/AURORA-519
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId>
struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the
getTasksStatus response in the future. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2

>   src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
3807c1253469ca3250c1e0137fcf848afe79d06f 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5

> 
> Diff: https://reviews.apache.org/r/22429/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message