aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 22792: Add test coverage for MesosLog.
Date Thu, 19 Jun 2014 21:50:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22792/#review46230
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On June 19, 2014, 9:38 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22792/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This brings instruction coverage to 86% in MesosLog, 81% overall.  Unfortunately in this
effort i learned of a shortcoming in jacoco, described here: 
> 
> http://www.eclemma.org/jacoco/trunk/doc/faq.html
> > Code with exceptions shows no coverage. Why?
> 
> > JaCoCo determines code execution with so called probes. Probes are inserted into
the control flow at certain positions.
> > Code is considered as executed when a subsequent probe has been executed. In case
of exceptions such a sequence of
> > instructions is aborted somewhere in the middle and not marked as executed.
> 
> http://bryanpendleton.blogspot.com/2012/07/java-code-coverage-and-thrown.html
> 
> This issue prevents us from achieving 100% coverage in MesosLog, and will do so in other
classes that throw exceptions.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java b8a94ff90dfcb4d18a79ae3d60fc8384eebf590f

>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 23c1d7a4190c58912d99009ae75bdd87488cd688

> 
> Diff: https://reviews.apache.org/r/22792/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message