aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 22663: Returning a message when no tasks to kill.
Date Thu, 19 Jun 2014 20:20:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22663/#review46220
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22663/#comment81514>

    This is at odds with https://issues.apache.org/jira/browse/AURORA-461, which set out to
only return informative messages.  Can you please follow up to omit this message?


- Bill Farner


On June 16, 2014, 11:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22663/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 11:46 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-533
>     https://issues.apache.org/jira/browse/AURORA-533
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Returning a message when no tasks to kill.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 94072cf61a9b218133ab625843e14cc195411130

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
bab8b9fdbce135a45b29b1e92cc4a0420f77cda8 
> 
> Diff: https://reviews.apache.org/r/22663/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message