aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Date Thu, 19 Jun 2014 18:35:13 GMT


> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > Can you verify that ./gradlew FlagSchemaChanges passes?

Done (I expect I'll need to do this again after a rebase). 


> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 429
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line429>
> >
> >     Drop @Nullable

Done.


> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 430
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line430>
> >
> >     favor immutability: ImmutableSet.copyOf(input.getValue())

Done.


> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 453
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line453>
> >
> >     ImmutableSet.copyOf(groups)

Done.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46207
-----------------------------------------------------------


On June 19, 2014, 6:34 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 6:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-519
>     https://issues.apache.org/jira/browse/AURORA-519
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId>
struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the
getTasksStatus response in the future. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5

>   src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
299679618f135f29bbf4e6372585ae46a1224a27 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf

>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434

>   src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b

>   src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a

>   src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259

>   src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f

>   src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151

> 
> Diff: https://reviews.apache.org/r/22429/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message