aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 22747: Add a python clean.sh script
Date Thu, 19 Jun 2014 18:23:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46208
-----------------------------------------------------------



build-support/python/clean.sh
<https://reviews.apache.org/r/22747/#comment81502>

    set -ux?



build-support/python/clean.sh
<https://reviews.apache.org/r/22747/#comment81503>

    double-quotes around all non-assignment strings
    
    AURORA_BASE=$(dirname "$0")/../..
    rm -fr "$HOME/.pex"
    rm -fr "$AURORA_BASE/.pants.d"
    rm -fr "$AURORA_BASE/.python"
    rm -fr "$AURORA_BASE/pants.pex"
    
    If you want to see why, try running this script in a directory whose name contains a space
like "/User/ksweeney/XCode Projects/incubator-aurora" (note: don't actually do this).


- Kevin Sweeney


On June 18, 2014, 4:03 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22747/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 4:03 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A script to clean out installed dependencies so I don't use the one in twitter commons
or pantsbuild.
> 
> 
> Diffs
> -----
> 
>   build-support/python/clean.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22747/diff/
> 
> 
> Testing
> -------
> 
> It works?
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message