aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 22457: Improve aurora "job diff" command.
Date Wed, 18 Jun 2014 14:57:22 GMT


> On June 16, 2014, 5:25 p.m., David McLaughlin wrote:
> > src/main/python/apache/aurora/client/cli/json_tree_diff.py, line 56
> > <https://reviews.apache.org/r/22457/diff/3/?file=609593#file609593line56>
> >
> >     Not a big deal given how rare it would occur, but you're using a delimiter that
is a valid key character, so you could have ambiguous keys. 
> >     
> >     i.e. given the path of "hello.world" and value True should that refer to the
path:
> >      
> >     { "hello.world": True }
> >     
> >     Or
> >     
> >     {
> >       "hello": {
> >         "world": True
> >       }
> >     }
> >     
> >     ?
> >     
> >     Returning the path as an n-tuple of keys avoids this.

But we know that these json trees are thrift; I'm exploiting the way that thrift serializes
as lists and dicts to build the diff. And thrift doesn't allow "." in field names.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review45832
-----------------------------------------------------------


On June 13, 2014, 4:22 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22457/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 4:22 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-520
>     https://issues.apache.org/jira/browse/aurora-520
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a new diff method, which uses field-by-field comparison of JSON trees for comparing
running job configurations to potentially updated configs.
> 
> - Allow exclusion of semantically irrelevant fields.
> - Provide a clearer list of the differences between configs.
> - Provide a scripting-friendly alternative JSON syntax for diffs.
> 
> The old diff behavior is still available under the "--use-shell-diff" option.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32

>   src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565

>   src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378

>   src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18

>   src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22457/diff/
> 
> 
> Testing
> -------
> 
> New unit tests of the JSON tree diff code, plus a bunch of new "job diff" tests of the
new functionality.
> All tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message