aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 22483: Adding /locks endpoint to expose update locks.
Date Fri, 13 Jun 2014 19:57:30 GMT


> On June 13, 2014, 12:44 p.m., Joe Smith wrote:
> > +1 to exposing this via thrift if possible- can we just start with getAllLocks and
getLocksForRole? (seems you're concerned about us publishing an API before its thought through..
however if we're adding this now it seems like we're doing that anyway)
> 
> Maxim Khutornenko wrote:
>     I am working on a getLocks rpc used in admin client. I am not ready to commit to
getLocksForRole as that would not make sense long term. Locks are not specific to role and
are identified by a LockKey union. JobKey is just one of the possible values in that union
and is the only one for now. That may change in future when we have a hierarchical storage.
Having an rpc that would allow wide range queries (similar to TaskQuery) would make more sense
then.

agreed, good points. thanks!


> On June 13, 2014, 12:44 p.m., Joe Smith wrote:
> > src/main/java/org/apache/aurora/scheduler/http/Quotas.java, line 58
> > <https://reviews.apache.org/r/22483/diff/1/?file=607807#file607807line58>
> >
> >     naive question- should there be a matching change somewhere else here? (at least
in a test maybe?)
> 
> Maxim Khutornenko wrote:
>     The name of the method is irrelevant to the endpoint.

kk, thanks! :)


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22483/#review45645
-----------------------------------------------------------


On June 11, 2014, 4:32 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22483/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 4:32 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-346
>     https://issues.apache.org/jira/browse/AURORA-346
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Needed to get all locks from the scheduler and apparently there is already a ticket for
that. Adding /locks endpoint.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38

>   src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22483/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> File Attachments
> ----------------
> 
> locks
>   https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message