aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 22489: Short-circuit preemptor on min-priority non-prod tasks.
Date Thu, 12 Jun 2014 18:02:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22489/#review45459
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java
<https://reviews.apache.org/r/22489/#comment80371>

    We now have two places where the filter logic is replicated. Do you really need it here?



- Maxim Khutornenko


On June 12, 2014, 1:21 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22489/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 1:21 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-524
>     https://issues.apache.org/jira/browse/AURORA-524
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Short-circuit preemptor on min-priority non-prod tasks.
> 
> Refactor the Preemptor to short-circuit when there's no hope a task could be preempted.
This will prevent hopeless preemption attempts from being included in the count, making the
ratio of (preemptor_no_slots_found / preemptor_attempts) a meaningful indicator of cluster
health. There may also be a small performance improvement, but that's not the goal of this
change.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5

>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 1be16374aeebaee59063aec982690ffa1fbdcf0f

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94

> 
> Diff: https://reviews.apache.org/r/22489/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message