aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 22483: Adding /locks endpoint to expose update locks.
Date Thu, 12 Jun 2014 02:01:57 GMT


> On June 12, 2014, 12:15 a.m., David McLaughlin wrote:
> > Curious why you didn't make this part of the Thrift API?
> 
> Maxim Khutornenko wrote:
>     I don't see a use case for it on the client. This data is rarely needed and for debugging
purposes only. 
>     
>     Is there something specific you have in mind?
> 
> David McLaughlin wrote:
>     The linked ticket wanted to use the information in the UI, so it would best if it
were part of a formal API (which I think should be Thrift until we design a supported REST
API).
> 
> Maxim Khutornenko wrote:
>     This is exactly why I don't want to invest into something without a use case that
is deemed to be reworked before it sees the light.

+1 for a thrift API. Since the UI can use it as well.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22483/#review45447
-----------------------------------------------------------


On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22483/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-346
>     https://issues.apache.org/jira/browse/AURORA-346
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Needed to get all locks from the scheduler and apparently there is already a ticket for
that. Adding /locks endpoint.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38

>   src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22483/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> File Attachments
> ----------------
> 
> locks
>   https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message