aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.
Date Wed, 11 Jun 2014 18:47:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45408
-----------------------------------------------------------

Ship it!


cool, lgtm other than ~nits


src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80253>

    I wish I could link to a better 'canonical' source, but I can't (the pep doesn't seem
to cover this[1]) but any chance you can follow the pre-existing style[2] for these?
    
    [1] http://legacy.python.org/dev/peps/pep-0287/#docstring-significant-features
    [2] https://github.com/apache/incubator-aurora/blob/master/src/main/python/apache/aurora/admin/host_maintenance.py#L57



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80258>

    _parse_hostname_list(hostname_list)
    
    (this is important because we also have a Hosts()[1])
    
    [1] https://github.com/apache/incubator-aurora/blob/master/src/main/thrift/org/apache/aurora/gen/api.thrift#L397



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80255>

    hostnames =



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80256>

    return hostnames



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80259>

    parse_hostnames_optional



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment80260>

    parse_hostnames



src/test/python/apache/aurora/admin/test_host_maintenance.py
<https://reviews.apache.org/r/22167/#comment80263>

    doh. thanks


- Joe Smith


On June 11, 2014, 10:04 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 10:04 a.m.)
> 
> 
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-445
>     https://issues.apache.org/jira/browse/AURORA-445
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751

>   src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION 
>   src/main/python/apache/aurora/admin/host_maintenance.py 71f27bfd5860fd7a2bdaee68efe6b418f5f191e0

>   src/main/python/apache/aurora/client/base.py 31155405ddac9d1433a316e5ca943f1a46e11472

>   src/main/python/apache/aurora/client/cli/__init__.py 4e018f14a4f45cfaf614d4c6e434dea6230a95c1

>   src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4

>   src/main/python/apache/aurora/client/commands/admin.py a9f81e8e0fb0abcb9266aa97a9e66da7af23c0aa

>   src/main/python/apache/aurora/client/commands/maintenance.py e4d60d47280ad6e18fff7f4b0d916b97c2f098f7

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 0341d35955a312fc28dbc6c4bab3564a3beb45b5

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py da8015ff417fb87a38b87964d9aa21d572a90a70

>   src/test/python/apache/aurora/client/commands/test_maintenance.py 827bd7f58f74d529fb9ac7c7c1049752b2004f19

>   src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44

> 
> Diff: https://reviews.apache.org/r/22167/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/tests/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message