aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.
Date Mon, 09 Jun 2014 19:17:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45109
-----------------------------------------------------------



src/main/python/apache/aurora/admin/admin_util.py
<https://reviews.apache.org/r/22167/#comment79777>

    Are you sure you uploaded the correct diff? In your reply to the review, you said you'd
added docs here - but I still don't see any.
    


- Mark Chu-Carroll


On June 3, 2014, 9:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22167/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 9:46 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-445
>     https://issues.apache.org/jira/browse/AURORA-445
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding SLA check into perform_maintenance_hosts command with the possibility of override.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/BUILD 8d850bcea353a0a4afe0135d600a890511bb6751

>   src/main/python/apache/aurora/admin/admin_util.py PRE-CREATION 
>   src/main/python/apache/aurora/admin/host_maintenance.py ca26de1e1a75aa4ae1c47ddd0f566b577c67fc7c

>   src/main/python/apache/aurora/client/base.py ef0855daf95b6bddb6788284102effde2599179b

>   src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05

>   src/main/python/apache/aurora/client/commands/BUILD 03cd4855464972e4ace6081f50d140ffbe5807c4

>   src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3

>   src/main/python/apache/aurora/client/commands/maintenance.py f6ebe3b0c665211f175f0b432a2fdae83fc7b62f

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 84a91d55516594dadc01408eb9d0b4773060d1af

>   src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab

>   src/test/python/apache/aurora/client/commands/util.py 84784171816797f3a4fa4c5238d19b626e68ff44

> 
> Diff: https://reviews.apache.org/r/22167/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/tests/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message