aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 22281: Fixing broken increase_quota command.
Date Fri, 06 Jun 2014 18:00:57 GMT


> On June 5, 2014, 11:32 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 213
> > <https://reviews.apache.org/r/22281/diff/1/?file=604420#file604420line213>
> >
> >     You can just use "int" here and elsewhere and don't really need to think about
overflow in python - see http://legacy.python.org/dev/peps/pep-0237/ for why.

Sure, done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22281/#review44868
-----------------------------------------------------------


On June 5, 2014, 11 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22281/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-514
>     https://issues.apache.org/jira/browse/AURORA-514
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Converted ram and disk to longs to make TJSONProtocol happy. Added unit tests.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 48c944e1ae0c9ea07ecf0ca6e1a8644c85a7b116

>   src/test/python/apache/aurora/client/commands/test_admin.py 40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b

> 
> Diff: https://reviews.apache.org/r/22281/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message