aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 22280: Implement a TRequestsClient as a prelude to kerberization.
Date Thu, 05 Jun 2014 22:07:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22280/#review44856
-----------------------------------------------------------



src/main/python/apache/aurora/common/transport.py
<https://reviews.apache.org/r/22280/#comment79451>

    Test coverage for this file is missing.


- Kevin Sweeney


On June 5, 2014, 2:58 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22280/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 2:58 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement a TRequestsClient as a prelude to kerberization.
> 
> Sending out for early feedback.  This could probably be shipped as-is but curious to
see how people feel about this approach.  This is the first bit of AURORA-515.  To add kerberos
support, we just need to add a dependency on requests_kerberos and inject KerberosAuth() as
the 'auth=' parameter to TRequestsClient with the proper service principal specified.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/BUILD 6968d62e663a3d45b86d665ca4090be49e6426a6

>   src/main/python/apache/aurora/client/api/scheduler_client.py 86ccdd982ddd678a8eb86f3d7be2761ced1d7b6c

>   src/main/python/apache/aurora/common/BUILD 0de0cf76c0f19a6cee44cfb558096d2ff010a014

>   src/main/python/apache/aurora/common/transport.py PRE-CREATION 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 6b23a4a5e23f0724e418cefaadb2429480353272

> 
> Diff: https://reviews.apache.org/r/22280/diff/
> 
> 
> Testing
> -------
> 
> Updated client/api tests for the new transport.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message