aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 22242: Fixing query command.
Date Wed, 04 Jun 2014 21:35:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22242/#review44763
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On June 4, 2014, 11:34 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22242/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:34 a.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-301
>     https://issues.apache.org/jira/browse/AURORA-301
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Reordered the status check with result retrieval, which was hiding the query status message.
Added some test coverage.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 919eea933a5a65396e64e05c739344f0c093c1b3

>   src/test/python/apache/aurora/client/commands/BUILD d5e497e491a0e526078b3389e9f194899f1795a2

>   src/test/python/apache/aurora/client/commands/test_admin.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22242/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/commands:admin 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message